Giora Guttsait comments

Results 64 comments of


                                            Giora Guttsait

Avoid implentation types in list parameters

@kcochibili `Collection` or `Iterable` aren't collection types, but are interfaces. `ArrayList` is a specific implementation of a collection, but @maguitoon wants is that the API will not bound users to...

Setting [hotkeys] on a button only activates hotkey if focused on the button

> You're welcome to create a PR What's your preferred way to solve this from what I suggested?

Setting [hotkeys] on a button only activates hotkey if focused on the button

> Can you elaborate on the suggested solutions, please? It comes down to two ways: 1. Some declarative Input flat, such as `` or something similar 2. Replace `this.hotkeysService.addShortcut({ ...hotkey,...

Setting [hotkeys] on a button only activates hotkey if focused on the button

> I'm OK with adding both. The latter isn't a breaking change. When you say both, do you mean Both or Either? 😅

Setting [hotkeys] on a button only activates hotkey if focused on the button

NP. Thanks for the availability 👍🏻

chore(core): nx plugin submission nx-pwm

ping 🏓

fix ci errors in circleci

@shaikatz @omerlh sorry for the sudden ping, hope you guys see this. The CI fails for different reasons, and most of them I fixed, but one I'm not entirely sure...

fix ci errors in circleci

cc @yaron-idan

Improve type guard for `.all`

That’s possible I guess if there’s a way to know if the predicate is a type guard predicate

Improve type guard for `.all`

Someone mentions the "built in `ReturnType`" type, this might help... altho, following [this issue](https://github.com/Microsoft/TypeScript/issues/7657): ```typescript interface Array { filter(pred: (a: T) => a is U): U[]; } ``` ```typescript type...