Fenggang Wang
Fenggang Wang
Hi @koleini & @edsiper, this is the feature i have discussed with you before. Now it is ready to be reviewed.
https://github.com/fluent/fluent-bit-docs/pull/530
> Is there an well known and tested 3rd party heap implementation, as an alternative? Most of implementations are customized versions. For this plugin, i have done customization as well.
@edsiper @koleini , could you please review this PR ?
@koleini ,can you help to review this PR ?
Hi @koleini , this is the doc PR https://github.com/fluent/fluent-bit-docs/pull/530 . Let me fix the format issue and fill up unit tests.
> Would be good to add tests if possible. Sorry，please ignore the request review, i clicked it by accident. I have tried to add some test cases, but failed to...
@koleini please review latest code if possible.
will continue to finish this pr soon, tied up by some other affairs.
Hi @leonardo-albertovich, sure. Thanks so much for comments. For data structure, it is just a simple `heap` structure. I do not think binary tree can replace it, but if possible...