Gil Tayar comments

Results 129 comments of


                                            Gil Tayar

🛠️ Repo: HTML reporter needs tests

There's no lack of browser automation tools, although not sure this is needed. I would go with a simpler snapshot test (i.e. save the HTML baseline file, and always compare...

es module cache is broken by testdouble loader / quibble

You're right! Once you `replaceEsm` then all imports are "new" ones and you don't get the old module, _even if you didn't mock it_! This is because the code lazy!...

es module cache is broken by testdouble loader / quibble

Small quibble (pun intended 😉): `td.replaceEsm` is async, so in your repro, it should be: ```js await td.replaceEsm('./empty-module.js', undefined); ```

es module cache is broken by testdouble loader / quibble

@connorjclark before discussing the issues you raised, I tried replicating your problem in a test, and couldn't reproduce it. This is because when resolving a module that is not mocked...

es module cache is broken by testdouble loader / quibble

Oh! That part was yours! I was wondering how it happened that in some cases `resolve()` gets called multiple times in the same function.:-) OK, looking at it again and...

Using testdouble esm loader with ts-node/esm loader on mocha leads to errors (Node 18.6.0)

@AlexZ-343 would love to get a reproduction repository so that I can debug it this week! It would make my life _much_ easier.

Using testdouble esm loader with ts-node/esm loader on mocha leads to errors (Node 18.6.0)

Reproduced! Working on it...

Using testdouble esm loader with ts-node/esm loader on mocha leads to errors (Node 18.6.0)

Found the bug! Fixing...

Using testdouble esm loader with ts-node/esm loader on mocha leads to errors (Node 18.6.0)

@searls did you create a release?

Using testdouble esm loader with ts-node/esm loader on mocha leads to errors (Node 18.6.0)

@AlexZ-343 looking into it.