Roberto Bampi

Soundness issue in index_twice_mut

5

While conducting internal unsafe reviews @cramertj found a soundness issue in `index_twice_mut`: https://github.com/petgraph/petgraph/blob/c78b5b13a816f1f0daf37f3964db0d33c6cbf38d/src/graph_impl/mod.rs#L1156-L1162 This is unsound because it uses a reference to `&mut *self_mut` after creating the first indexed-value reference,...

Global middleware

1

Currently it seems like there is no way to create a middleware that acts on a request before it's routed. I think that it would make sense in some use...

Possible soundness issue in ChildImp::wait

1

While conducting an internal unsafe review, we identified a possible soundness issue in `ChildImp::wait` https://github.com/watchexec/command-group/blob/b88296fed10b18aebb7ad5889dab5e43b621297f/src/tokio/child/windows.rs#L100-L104 This function and the one below call the `Clone` impl that appears to undermine the...

Possible soundness issue in JobPort::Drop

1

While conducting an internal unsafe review, we identified a possible soundness issue in `JobPort::Drop` https://github.com/watchexec/command-group/blob/b88296fed10b18aebb7ad5889dab5e43b621297f/src/winres.rs#L35 This is highly suspect when combined with `#[derive(Clone)]` on the struct: any use of Clone...