Taka Kojima

Results 14 comments of Taka Kojima

I needed it published as an NPM package so I published a new package under a new name. I mention the fix at to top of the README, I thought...

@elus yeah, that was my bad.... https://github.com/gigafied/node-jsdoc-toolkit/commit/57b571e51fc3697378bbc6cb50d2ede460d1ab33

I was going to add it in that last PR, but then I realized it might not make much sense. Seeing as NPM is included w/ node by default and...

I can't merge this in it's current form because this will introduce the need for a special `animated-outlet` helper. I have some other ideas to fix this, while still not...

`ContainerView` should check the view type for old view and new view and treat them differently. The modification to `ContainerView` is must less intrusive so this should be fine to...

See https://github.com/gigafied/ember-animate/issues/17 I could probably refactor it some, maybe even having checks for the view type in `ContainerView` so that normal views work too. I just don't have time at...

Is there a particular issue you ran into because of this, or that it just doesn't seem right? I agree it's not really right, could probably be implemented better, but...

@narkeeso @billdami Yep, this is definitely true, however I think the behavior for nested views should be to not call the `destroy()` on child views until the parent view's `animateOut()`...

Yeah, the `animateIn` and `animateOut` hooks should be supported for this use case. I'll look into it, sometime next week and see if I can fix it.

Sorry guys, haven't been able to look into this yet. @buckyflowers solutions seems like the best way to solve this for now, and is pretty simple.