Tomasz Kostuch

Results 18 comments of Tomasz Kostuch

> In my attempt to mitigate this, I used that "loaded" flag that is set when when the data is loaded from the server, and in my asyncValidation validator, I...

Look at this example https://jsfiddle.net/07cmjweb/ I added `$dirty` flag. So now validation check if page is loaded and also if input was touched. Also text input emits `input` event so...

That's true, you can use debounce function to avoid checking validation with every letter. Good luck :)

Can you reproduce it in [jsfiddle](https://jsfiddle.net/Frizi/b5v4faqf/)?

you can do something like this ``` if (this.$refs.carousel) { const slides = this.$refs.carousel.$children || [] slides.forEach(slide => { slide.clickable = true }) } ``` here is fix for lib...

Hey, I can't tell you what is wrong. You need to debug it.That is not enough information to get answer. Stack trace from error shows that it occurs here: https://github.com/DivanteLtd/mage2vuestorefront/blob/master/src/adapters/nosql/elasticsearch.js#L110...

Maybe we can extend searchAdapter or make new module that will wait for idle time and then fetch those resources: ![Screenshot_13](https://user-images.githubusercontent.com/42383376/73687585-a7285d80-46ca-11ea-83e0-1b54d10611f0.png) This can reduce Time to Interactive by 1s

Also there are loaded banners files for other languages, but this is probably more related to core. ![Screenshot_15](https://user-images.githubusercontent.com/42383376/73687824-2027b500-46cb-11ea-9787-d67115f8e436.png)

related https://github.com/DivanteLtd/vsf-capybara/issues/27 stars values are hardcoded, that is why it looks different. TODO: - test endpoint with rating value https://github.com/DivanteLtd/magento2-review-api/blob/develop/docs/api-specs.md - add to payload rating value

@ArieRym if you want to have reviews then yes you need to install this plugin. But rating is not added to payload