ghurstunither

Results 7 comments of ghurstunither

> +445k LOC 😆 great work @ghurstunither and co Thanks! That number is a bit deceptive since the unit tests are stored in Wolfram notebooks (https://www.wolfram.com/notebooks/) -- which are not...

> Currently the Mathematica extension is building using C++14, however OpenVDB v10 uses C++17. So I believe this needs to be changed Good catch, updated `BuildSettings.m` to use C++17.

As a workaround you can find the symmetric difference with ``` csgUnionCopy(csgDifferenceCopy(grid1, grid2), csgDifferenceCopy(grid2, grid1)) ``` or ``` csgDifferenceCopy(csgUnionCopy(grid1, grid2), csgIntersectionCopy(grid1, grid2)) ``` For an in-place workaround, this might be...

> Should we close this PR and re-open using the feature branch as the source? Yes, I’ve gone ahead and closed this one.

> LGTM @apradhana feel like this covers some similar ground as the smooth union (e.g. https://iquilezles.org/articles/smin/) but imagine there is still place for both of these operations? That's a good...

> Needs a change for the log Is that something I add in this PR? > would be ideal if we could add a simple unit test that exceeds 32-bit...

> I think there's actually more to talk about here. The Tree and RootNode also make assumptions that the number of leaf nodes cannot exceed 2^32: > > https://github.com/AcademySoftwareFoundation/openvdb/blob/master/openvdb/openvdb/tree/Tree.h#L116 >...