Greg Greenway

Results 121 comments of Greg Greenway

@zuercher assigning to you as you have expertise in related areas. Feel free to re-assign if needed. But this has sat unassigned for awhile so trying to get it some...

> Yes, we doesn't change socket options when hot-restart, the existing socket option already applied on the socket which passed from the parent, the OS suppose ensure there is no...

> The simple solution here is to suggest the user don't change the socket option when hot-restart, the user can do another update for socket option after hot-restart. Also the...

Yeah, hot-restart should be a separate PR if/when someone wants it. I agree with merging this post-release.

The labels in a prometheus metric MUST be unique, according to the spec.

I'd say "unspecified value wins" and increment a metric or log an error; this is a configuration error, even though it can't be detected at config load time. Defining an...

If you want to change existing behavior, you're going to need to go through a deprecation cycle of the existing behavior, which roughly looks like adding a warning of using...