Michael Go comments

Results 5 comments of


                                            Michael Go

Add the :nearest_slave role for Sentinel mode

@cheald Can you update your PR please? This PR would be amazing to be merged.... One of our redis replica is in US Eastern, and one of our Rails instance...

font_url displays error with preload_tag due to whitelist

Hello @skooch ! I apologize for the late reply on your issue 🙏 The `font_url` is not a filter from the Liquid gem; it is a custom Liquid filter from...

extconf.rb Makefile compiles binary into wrong directory depending on OS

Hello @mgmarlow ! Can you still replicate this issue with the latest version of `rb-sys`? I currently can't replicate this issue. Does this issue happens even if you empty your...

Remove blank nodes from AST with omit_blank_nodes option

> I think this means comments won't be available in the AST anymore right? That might break tools using AST walking to inspect comments. > > I only know of...

Liquid::Template.parse(text) error in rspec after ver 5.6~

It looks like you are using the old version of `strscan` 🤔 The gemspec should force the gem users from using a gem version that is `>= 3.1.1`. https://github.com/Shopify/liquid/blob/1c1e7119065b0fa915149b9e2bdc303490a0dfff/liquid.gemspec#L31 Also,...