Giovanni Capalbo (Therp)

Results 12 comments of Giovanni Capalbo (Therp)

is xpathing by number safe? every time I see that i think "who tells you it's always going to be second?" I prefer name, looks safer.

@Saran440 thank you for testing removed utf, added a name to the action "children of {parent}" ![screenshot_parent1](https://user-images.githubusercontent.com/8994879/76318625-4817c300-62de-11ea-93f3-307fcad6cee3.png)

@janverb thanks for the great review and the catch of the parent name conflict. implemented all your suggestions.

Added consistency in licensing , set version to 12.0.1.0.0, rebased.

> Hmm.. Maybe I'm missing something here. How does one apply the 'is in selection' operator. Is it broken by the latest commit? Or maybe I don't understand the readme...

> @gfcapalbo The error occurs when selecting on a non relational field (like Author or Description). These have no tree views or list, so an 'in selection' filter makes no...

seems like pre-commit cannot find "python3.6" i have same problem on local , made some changes/updates in precommit, without decreasing checks, and then added some small lints. On local CI...

@legalsylvain @AaronHForgeFlow I have tried updating a bit of things in my pre-commit , and locally it now works, all green. It seems that we require python 3.7 as default...

CI fixed, by replicating the setup on other branches, the checks are effectively the same . please double check. All work concerning the hook fix in 1 commit. All work...

**summary of technical findings TL;DR:** The module adds an extra orderline for products that have a deposit product. These deposit product orderlines are then saved in the backend upon confirmation....