gerald

Results 68 comments of gerald

The random module is replaced by the rand module, if dropping the random module, I can make some code to it.

@werbitzky Do you have time to review this pr? We really need it.

At first glance, it uses queue to handle workers, it is a very good idea. Since some code was fixed in #104 , would you rebase your branch to master?...

The erlang:get_stacktrace/0 function keeps the latest error stacktrace info, no matter what code place it is in. You can try it in the shell, and you can still get the...

Ther `erlang:get_stacktrace/0` function only keeps the most latest error info, no matter what place it is put into. You can try this code below: ``` try 1/0 catch _:_ ->...

If `gen_server:cast(Pool, {cancel_waiting, CRef}),` causes a error, then it crashes, and it won't run into the `erlang:raise(Class, Reason, erlang:get_stacktrace())`.

Ok, I think you are right, and this pr can be merged.

@fishcakez Would you rebase to current master branch?

@tsloughter handshake/[1,2] always returns a new socket. The functions might be changed like this: ``` -ifdef(OTP_RELEASE). ssl_accept(ClientSocket, SSLOptions) -> ssl:handshake(ClientSocket, SSLOptions). -else. ssl_accept(ClientSocket, SSLOptions) -> case ssl:ssl_accept(ClientSocket, SSLOptions) of ok...