Geser Dugarov
Geser Dugarov
I've reverted back changes in `TestHoodieTableSource`. Couldn't figure out quickly, why there are differences in running on my local machine, work cluster vs Azure pipeline. But the difference in the...
@hudi-bot run azure
@hudi-bot run azure
I don't understand what is happening with CI. I've changed 2 unit tests: - `TestJavaHoodieBackedMetadata`, from `hudi-client/hudi-java-client`, - `TestHoodieDeltaStreamer`, from `hudi-utilities`. Both are Java tests. ### Azure CI `hudi-client/hudi-java-client` is...
@hudi-bot run azure
@mzheng-plaid @ad1happy2go The issue could be closed. Fixed in master branch: 7fc5adad7aa9787e961c36536a08622f62fabe49
**Before changes in this MR**, bucketing using timestamps is wrong. To illustrate it, a test for bucket pruning could be used: https://github.com/apache/hudi/blob/e0b12fbae5d69ee2101806d78f04672c1e5deb6f/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieTableSource.java#L245-L256 To calculate hash for bucketing `KeyGenUtils::extractRecordKeysByFields` will be...
> Having ':' in key value is not prohibited and it may occur easily, so we should process it properly instead of throwing exceptions. Thanks for your review! I would...
Updated unit test cases, when only one column is used for record key. In this case, we expect `value`, `column_name:value` is not possible due to: https://github.com/apache/hudi/blob/9b3f85e1b4d037a6e10c81e4b8d5f3e8a4a01ef6/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/BuiltinKeyGenerator.java#L249-L253
I don't understand costs in terms of performance, that we should pay for this change. There are a lot of work that was already done, and there is still a...