Gehan Gonsalkorale comments

Repositories
Issues
Comments

Results 5 comments of


                                            Gehan Gonsalkorale

Improved handling of origins and lambda triggers

Will update. Changes should not break anything but will confirm.

Improved handling of origins and lambda triggers

> Wonderful PR, I also encountered with exactly same issue like > > ``` > InvalidArgument: The parameter origin ID must be unique. > ``` > > @gehan Can you...

Improved handling of origins and lambda triggers

@krish-dev oh yes sorry I see! misunderstood. i'll check my PR for breaking changes 👍

Improved handling of origins and lambda triggers

> LGTM aside from just a few things as per my comments 🚀 > > It also doesn't seem like the change would be breaking, could you confirm? Long delay...

Assumes any url with s3 in it is an s3 bucket

I did a PR for this - https://github.com/serverless-components/aws-cloudfront/pull/19