Graham Bing

Results 16 comments of Graham Bing

Seems to me there's two problems. UtilityAreaTerminalView.swift:247 ``` .onAppear(perform: initializeTerminals) ``` is reinitializing `terminals` every time the view loads and should be changed to something like ``` .onAppear { if...

> You checked the box that you would like to work on code for this... what did you have in mind? When i checked that box I had been poking...

- How does it look in smaller windows? Not even absurdly tiny, but e.g. a 3/4 screen width window on a 13” Macbook Air at default screen resolution with both...

To be clear, does this break compatibility with [existing converted coreml models](https://huggingface.co/coreml-community)?

It looks like the executable bit was erroneously set on every file in this PR and should be set back. This will have the added benefit of reducing the Files...

I suggested a few nitpicking code changes, but I think that the real questions about this PR are much broader. - does this seamlessly reproduce all existing Mochi functionality? -...

Variable size is a really cool hack, and I definitely think the functionality is worth the hackiness. But it can be cleaned up and made a little less hacky. Most...

> I don't think it's necessary. If you choose to use the new function of mochi, you must use GuernikaModelConverter to reconvert the model. The new model will only apply...

I’ll take a closer look at this later but I have some quick initial questions you might be able to answer - is the new metadata format documented anywhere? -...

> The original Metadata remains unchanged, the old code is just moved to the new metadata function. This isn't right, what I mean is that the metadata from a random...