Gabriel Daiha

Results 6 comments of Gabriel Daiha

Man, great PR! This will help a lot users that wants to keep .py module files with their own extension.

> You mention that memory is high for both fit and effect: do you mean that while running those methods memory usage spikes but then comes back down to a...

Another important detail. I was using a treatment dataframe with featurizer, making me have 6 columns in T. I was inspecting code, and, in many steps, they use a cross...

Can't understand exactly why these tests are failing. The only thing I've done here was to move impurity_improvement after the calculation of best.impurity_left and best.impurity_right and changed impurity_improvement signature. Tests...

I'm going to implement tests to this new feature

pr is ready to review. tests implemented. @kbattocchi , could you rerun the two tests failed due to a temporary unavailability of uv?