Rene Gassmoeller
Rene Gassmoeller
I agree this is currently not the approach we should take. I suggested unity build groups, because I was under the impression we can have one group per directory (one...
I agree with @tjhei, having the world build as a shared library brings us many other advantages as well, so any energy we spend on another solution will only distract...
@ahollyday I added WIP in the title to show other reviewers that this is not meant for review at this point yet. Our plan is to merge this manually with...
@mfmweerdesteijn The statement you mentioned checks if the geometry model is best described in spherical coordinates (i.e. a spherical shell or a piece of it, or an ellipsoid). This is...
The if-statement was copied from another place that works for both cartesian and spherical geometries. If we assert that this postprocessor is only run in spherical geometries the if-statement can...
@jdannberg is this ready to merge?
Also you should definitely add a changelog entry for this, and give us a reference to any publications that should be cited if users enable the fastscape coupling (we will...
@tjhei: I asked @elodie-kendall to open this PR in an incomplete state to be able to leave comments directly on the code. I will add some more comments later.
Ah, I do not remember the details of what we discussed, but I might have misled you. I checked our paper again were we made the convergence rate analysis and...