garro95

In my opinion it could be useful to add in the design doc or in other document for contributors the meaning of the issues labels

Feature request: Date::and_seconds_from_midnight(&self, seconds: u32) -> DateTime

1

In GTFS, arrival time at stops is indicated as seconds from midnight. In this case, to generate the correct DateTime in chrono, I had to do ``` Local::today().and_hms((*arrival.0)/3600, (*arrival.0/60)%60, *arrival.0%60)...

Documentation

2

Please, improve the crate documentation. I suggest adding specific documentation to the derive macros sections, possibly with examples. In particular the documentation does not say anything about CopyGetters and MutGetters....

`IndexMap` `Equivalent` trait allows to have a special implementation of `Eq` to use inside the hashmap but different from the `==`. `IndexMap` provide a default implementation of `Equivalent` for types...

The examples in the examples directories have few or no comments on them. This makes it harder to read them

Shortest path algorithms inconsistency and documentation

7

Why do the algorithms for the shortest path have different interfaces? In my opinion, they should return a struct that lets one obtain the information they wanted, like a path...

I want to help

4

I would like to help to maintain and develop this project and rusty-machine too, during my free time. I have some experience in statistical machine learning and linear algebra and...

De/serialization with serde

1

This pull request add serialization and deserialization with serde for matrix and vector and related tests

Use traits instead of structs

8

The Genotype iter and into_iter methods should return a Type that implements the Iterator and IntoIterator traits and not the specific implementation of these traits for slices. This would improve...