Garret Rieger

Size appears to be taken up be both the expected files and the input font files for the tests. For the input font files: we include quite a few full...

Looks like we have layout-features but not layout-scripts: https://github.com/harfbuzz/harfbuzz/blob/main/util/options-subset.cc#L305

Add support for --layout-scripts shouldn't be too much work, I'll see if I can do it.

I'm thinking we should have the harfbuzz api return an error code which will indicate the specific reasoning for the failure (ie. memory allocation failure vs repacker ran out of...

Right, which can mean that the rendering for the subset will end up being different than for the whole font where the single combined glyph is used instead of the...

We have a python script that handles subsetting these fonts here: https://github.com/rsheeter/subset-gf-icons/blob/main/src/subset_gf_icons/subset_gf_icons.py Your description of what you need to do is pretty much the same, but the missing step is...

> 2. Do we have an easier way to subset this font? No need to get gids via hb-shape, like adding a new `--gids-name` flag. There's an existing flag that...

Yeah currently the cli can't run the closure for you, that's currently only available via the c api. It's possible we might want to add a new flag to the...

> imho we would want a new cli as we don't know typically know the glyph names, just the icon names. > > > I expect eventually the hb-subset CLI...

> A warning or somesuch would be nice. The API documentation specifies that all axes must be pinned currently: https://github.com/harfbuzz/harfbuzz/blob/main/src/hb-subset-input.cc#L408