garnacho

Results 9 comments of garnacho

Just FWIW, pad events are abstracted at a higher level through [GtkPadController](https://developer.gnome.org/gtk3/stable/GtkPadController.html), which allow assigning GActions that get activated when a button (in the right mode, if specified) is pressed....

I've read through the changes and the proposed API makes sense to me. I feel there should be further documentation on the expected order of events after the `SelectionTransfer` signal,...

Looking at the DBus interface and implementation this makes sense to me. A slight concern I have is about the fine grained capabilities that are captured in `CreateSession`. On one...

> Just for the record, we can differ between **capturing** (portal) and **transmitting** (libei) events. In the case of synergy, we cannot **transmit** touch events, they're not supported by synergy....

@parkerlreed as it seems, you are already using the XDG portal, and it is not playing ball: > [2024:05:06:21:09:25]: Error: Could not select sources: GDBus.Error:org.freedesktop.DBus.Error.AccessDenied: Invalid session This `...AccessDenied: Invalid...

> @garnacho Thank you for the PR! Would you mind signing the CLA? Sorry for the delay in response... I unfortunately completely missed [the parts](https://docs.lizardbyte.dev/en/latest/developers/contributing.html?lng=en#legal) talking about the CLA requirement...

Sorry, I've been off the grid for personal reasons since late Aug... It is great news to me that a CLA is no longer required, since the legal department of...

Thanks for the preliminary review @ReenigneArcher! > Looking forward to this PR! From my understanding this can replace our KMS/Wayland capture, and no setcap will be needed? In principle, yes...

A thing I forgot to assert/reply, this indeed does not require setcap, and allows Sunshine to run with plain user permissions within the environment of a desktop session capable of...