gardnermj
gardnermj
I'm no ObjC expert, but based on what Jordan wrote I think they just need to be reversed, i.e. to `CKRecord *_Nullable *_Nonnull inOutRecordPtr`.
But absolute-path returns a String, doesn't it? That's why I assumed it was the implementation and not the docstring for normalized-path that needed fixing. Either way works for me, as...
Any thoughts on implementing this? I might take a stab at it soon; any guidance would be helpful.
I've implemented multi-value support for ID3v2.4 text frames: https://github.com/oueqzoms/mp3agic/commit/c06d8da0b24969b98f41b90fdb06048dfac691df. Before I start working on tests, could you let me know what you think of the API changes?
Thanks for the feedback. Do you have any opinion on what type of collection the plurals should return? I used String[] because it was convenient, but I'm rusty with Java...
@hennr, varargs would make it awkward to provide values from a collection, which seems likely to be the most common scenario. That doesn't feel like a good trade-off to me....
Would it be better to put the plural getters in the ID3v2 interface, so that ID3v2.x tags can all be read in a consistent way? The non-2.4 implementations would just...
After some more thought, I would now advocate having the plurals use Iterable. But if the consensus is still for String[], that's fine too. In the event that there is...
Ah, that's unfortunate. Thanks for the pointer; I don't know if I'll have time to implement it either, but I'll let you know if I do.