Gabriele Ciccotelli

Results 6 comments of Gabriele Ciccotelli

Thank you @mihaimaruseac for your feedback! Regarding the newline character, I will address it right away. For the two comparison functions, the reason I chose to use an `if-else` structure...

Hi @mihaimaruseac, I have updated the PR as requested: - Inverted return values in `WeightedDeltaCompare()` and `KeypointCompare()` (return `1` if `a < b`, `-1` if `a > b`, `0` if...

Hi, I have analyzed the logs generated by the failed tests. ### Py+CPP Test Suite For the following tests: - Presubmit - Linux Arm64 CPU Build Tests only - Py+CPP...

Hi @mihaimaruseac, Based on the errors reported by the tests, I made the following changes: - Moved the definition of the `WeightedDelta` struct to the header file (`frame_pair.h`). - Declared...

Sorry @mihaimaruseac, I only just noticed that you had already made the change.

Hi @mihaimaruseac, I had to move the `testonly = true` attribute up in the code to prevent the `Presubmit - Code Check` check from failing