Németh Gábor
Németh Gábor
Looks good! 👍 Could you add tests for verifying the successful parsing of splits and photos from the sample json?
@Laperuta Could you add sample JSON activities response as a resource to the test project and verify the splits and photos info getting parsed? The tests executed against my activities...
Rebased in #35
It totally makes sense, although we still won't get notified through the tests if some change in the Strava API breaks the code in production. And we have to update...
I would only mock the service of Strava API, but not the POCOs. I'm still concerned about maintaining a service mimicking Strava API, because we have to constantly watch for...
Closing this according to #20 Test runs should be fine now on Azure DevOps. Access token is getting refreshed by the test authenticator with the credentials provided as secrets in...
I have already cleaned up these changes [into a new branch](https://github.com/gabornemeth/StravaSharp/tree/interfaced-version). It's time to re-align it again though. I like the concept generally, but don't like some parts, e.g. relying...
I'm changing some test cases - which are hard to run against real data on Strava - by simulating the response from the API. Good samples can be grabbed from...
If this is going to be merged, my pull request has to be canceled, as it fixes the same errors but not all of them. https://github.com/xamarin/monodroid-samples/pull/73