Gaal Yahas
Gaal Yahas
> One: given the code comment specifically mentions it being implemented as a union of the filters, it would be more flexible as an array of filters/filter functions which are...
The vast majority of Google callsites use this for logging. How would putting it closer to logging look like, though? Just copy the current type into packages log (and glog)?...
I forgot to mention, though, that it's also used to throttle t.Log and ctxlog. Those have similar requirements, but it would be odd to add Sometimes to packages testing and...
I checked to see whether that would clash with any identifiers named `some`, and the answer is not really (there are a tiny number of cases with variables named some...
I've updated the CL and description based on the feedback above. PTAL and let me know if there's anything left to do in order to proceed with the proposal. Thanks.
Updated back. Personally I prefer rate.Sometimes, as it would make my life easier.
The action is allowed if any one of the Sometimes conditions is met.
Thanks for the patch! This repo is managed internally but I'll apply it there. Expect this to be merged some time this week.
The fix has been applied upstream and pushed. Thanks again; I'm closing the pull request now.
Thanks for the patch! This repository is managed internally so we cannot merge it directly. I'll get this integrated in our repo and have it pushed this week.