German Gonzalo Saracca

Results 74 comments of German Gonzalo Saracca

@ErykKul There are two storybooks, one for the Design System components only and one for the SPA. You should create the story about the FileUploader in `src/stories/upload-dataset-files/UploadFiles.stories.tsx` Many thanks!

> Do you mean an extra one, for the file upload element only? A story for the UploadDatasetFile page that includes all the elements inside it is fine, as the...

Hi @ErykKul , the scope of the issue is just to create the FileUploader component (dropzone) and a callback to get the files processed from it ( I believe ),...

> If you find a moment, can you take a look at the code as it is now? Thanks! Sure, I will try to take a look at it tomorrow....

Glad to help! 😄 I think that all the features like abort controller, progress etc are going to be necessary, I think it's good if you keep them. What I...

Hi @ErykKul , try passing an aria-label attribute as a prop, should fix it, even better you could detect if not aria-label prop has been passed you could set one...

> @GermanSaracca There is still a difference between the form validation and the API validation - from my testing, I think the API validation is requiring that the email address...

I completely agree, I will fix those eslint warnings, thanks @ekraffmiller

@ekraffmiller Eslint warnings were addressed 👍🏼 , thanks!

Update branch with latest changes from develop. Add one more asertion to the dataset title. I took the opportunity to change the dataverse logo in the header, the current one...