Fyodor

Results 16 comments of Fyodor

Store is a kinda opinionated mental model. And not a bad one. It allows to separate concerns of actions (or updaters in this case, as you use Component Store), effects...

Well that makes sense. Anyway, if you don't see any use of the stores in future and you feel much more comfortable without them, why not get rid of it....

@cmgorton I would suggest a couple of options here (I mean I could work on possible implementation, of course). First, more consistent one - add a menu button, which would...

@valentinpalkovic I have updated the lib tests and they seem to pass successfully in CI/CD env: But the suite for `cli` fails because of the similar `internal-ip` ESM import issues...

@valentinpalkovic thanks a lot for the Midas touch, I got pretty confused tbh 👍😅

Hi guys, I was reviewing the `ip-address` code during work on this PR but looks like there's no directly suitable method there to swap `ip.address` with. I wouldn't go for...

@cosieLq cool, looks reasonable, I'd only suggest to add the proper test coverage using one of existing functions there as an example — also if there are (should be, I...

@valentinpalkovic which branch should I target the fix PR to? Hadn't found any rules/strategies on that. As I can see, most of the PRs are targeted to `next` but I...

@valentinpalkovic made the suggestion via https://github.com/storybookjs/storybook/pull/26025, please review, any feedback is welcome, as I'm a first-time contributor here.

Hi Bunyamin, Thanks a lot for taking time to report that. I will be able to check the issue more thoroughly in a couple of weeks and come back to...