Frances Wingerter

Results 99 comments of Frances Wingerter

This looks like a duplicate of #353, which has been fixed (but not in a released version, it seems). Can you try building from git (or one of the other...

I've confirmed this behavior. A few notes: - This C code (without `stdbool.h`) does not compile unmodified with GCC or Clang--the header really is needed for correctness. - Replacing `true`...

Looks like it was https://github.com/rust-lang/rust/pull/97423 that broke this. I'll see about a fix.

Now we hit an ICE on `unsupported cast: *mut libc::c_void to usize`... I think it may be that we need a different `CastKind` in `cast_ptr_to_usize`.

> `./scripts/test_translator.py tests/ --only-directories builtins` is also broken now: Oops, I forgot to save some changes before committing. I'll push a fix. > By the way, these error messages are...

Based on the error message, it sounds like we're trying to do something illegal with `*const [&str]` (perhaps casting it to usize?).

Adding this assertion seems to pre-empt the later error: ```diff diff --git a/dynamic_instrumentation/src/point/cast.rs b/dynamic_instrumentation/src/point/cast.rs index 4b5db5fa..25799dba 100644 --- a/dynamic_instrumentation/src/point/cast.rs +++ b/dynamic_instrumentation/src/point/cast.rs @@ -29,6 +29,12 @@ pub fn cast_ptr_to_usize

A personal belief of mine is that `utils` is never a good name--if the code weren't useful, it wouldn't be written; if it's related to some given goal (i.e. "build",...

As far as `find_llvm_config` goes, is there useful sharing of implementation details between that and the existing `Sysroot` struct? If we were going to put this crate on crates.io (I...