Francesco Vasco

Please allow `h264_nvenc` encoding on NVIDIA hardware, it is really, really fast. Otherwise, please set an advanced text field to set a custom codec.

A better option than `javaClass`, it does not work everywhere (only JVM backend). apply/let/also do not require external dependency or extra bytecode.

Extraction error when using BNE edition without tome assets

14

I downloaded the italian version of Warcraft 2 here https://archive.org/details/W2BNECDITA I am using wargus `3.0.0-0~202012191004~ubuntu21.04.1` I mount the Warcraft CD, I found the file install.exe ~~~ $ md5sum install.exe b9a123ad486f5d0674238de31f51fa4c...

SnakeYAML requires the java.desktop module

1

The `java.desktop` is a quite huge dependency for a parser, please consider avoiding this dependency or parse the Yaml at compile time (this improves performances too). ~~~ java.lang.NoClassDefFoundError: java/beans/IntrospectionException at...

The [PriorityClass](https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/#priorityclass) class backup should be added to default.

Consider annotate code with JSR 305 nullability annotations (package already included). This will become part of documentation and it is well integrated with IDEs or Kotlin language.

Colors as enum

1

Consider to replace `Colors` class with a proper `enum` ``` public enum Color { BLACK(144), WHITE(5), RED(28), CYAN(159), PURPLE(156), GREEN(30), BLUE(31), YELLOW(158), ORANGE(129), BROWN(149), LIGHT_RED(150), GREY1(151), GREY2(152), LIGHT_GREEN(153), LIGHT_BLUE(154), GREY3(155);...

Consider to implement a PETSCII [Charset](https://docs.oracle.com/javase/7/docs/api/java/nio/charset/Charset.html) and reconsider the `CbmInputOuput` class (warning: missing "t").

`0` is faster and more readable then `INTEGER_ZERO`. https://github.com/sblendorio/petscii-bbs/blob/0a9546a74f4b73c5c13ff9fc32d61855bcfa215d/src/main/java/eu/sblendorio/bbs/core/BBServer.java#L26

Consider using [ServiceLoader](https://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html) instead of reflection. `ServiceLoader` is a standard way for pluggable component, so you can remove the home made `Hidden` annotation. https://github.com/sblendorio/petscii-bbs/blob/0a9546a74f4b73c5c13ff9fc32d61855bcfa215d/src/main/java/eu/sblendorio/bbs/core/BBServer.java#L103