fuzzard
fuzzard
osx failure is due to clang warnings limit. That is, clang found new warnings with the code, which goes over the threshold, causing the failure. https://jenkins.kodi.tv/job/OSX-64/25752/clang/category.2119183113/folder.1802370034/
At a quick look, i dont believe they use String::null anymore internally. Looking at the constructor at https://github.com/taglib/taglib/blob/a8884c2b17f5615bfc4260698a1f6d5fe51a6bb0/taglib/mpeg/id3v1/id3v1tag.cpp#L86-L89 that inits https://github.com/taglib/taglib/blob/a8884c2b17f5615bfc4260698a1f6d5fe51a6bb0/taglib/mpeg/id3v1/id3v1tag.cpp#L41-L60 Of which default constructor of String for title will...
Thanks for the PR. If you do venture further into pictures and need any reviews/questions, reach out on the forums and we'll try get you any assistance you need.
I understand the reasoning, and agree with the thinking, but i believe the approach is incorrect. I'll break it down into the 2 core reasons 1) Jenkins handling. 2) build...
Thanks for the PR, i'll merge it for Alpha 3 and see what shakes out.
have seen this failure building for osx as well. this was built with the following configure command ./configure --disable-shared --disable-utils --disable-examples --disable-werror ``` nfs_v3.c:4986:9: error: implicit declaration of function 'nfs_mt_mutex_lock'...
was just told there were some patches in master by a colleague. I'll have a look. Any chance of a quick turn around on a point release if it does...
i'll test this evening against our platforms
Has successfully built against platforms Kodi uses - ios/tvos/macos x86_64/android arm/aarch64/ linux x86/arm/aarch64 using autoconf make
probably not intended to blanket enable lto. im guessing a rebase error. Because ive been fiddling in this area recently, i think what you would be after would be ```...