Suiyi Fu comments

Results 11 comments of


                                            Suiyi Fu

Decode PLAY_SESSION cookie string to map?

seems the author already managed to solve it in his own from what I see in stackoverflow

Support error codes in packet readers and writers

Is this issue dependent on #302 or can be done independently?

Implement simplest "beep" and "echo" PLC

I can take a look at this:D

Implement simplest "beep" and "echo" PLC

Hi @gavv if I understand correctly, https://github.com/roc-project/roc/blob/develop/src/modules/roc_audio/depacketizer.cpp#L108-L114 each time we should either `read_missing_samples_` or `read_packet_samples_` so that each time it is either `FlagBlank` or not `FlagBlank`?

Implement simplest "beep" and "echo" PLC

yes I saw #302 , cool I will take a look at the unit test:)

Implement simplest "beep" and "echo" PLC

since this is a task after #302 may I look at this other issues first:)

Ring buffer for packets without session

I can take at look at this, but I will certainly give it back to @biljith if he returns and the issue is still open.

Ring buffer for packets without session

does `pipeline::Receiver` change to `pipeline::ReceiverSource`?

Ring buffer for packets without session

``` Find the place where Receiver::fetch_packets_() drops packets (when it gets false from route_packet_()), and make it store the packet inside the ring buffer instead (add the packet to the...

Ring buffer for packets without session

HI @gavv I created a draft pr #357 want to make sure if I am on the right path. Are your previous comments on the unit test still applicable? Thanks!