Matias Furszyfer
Matias Furszyfer
Thanks for the feedback! Rebased on master, conflict solved. Ready to go. ----------------- > ACK [616a54b](https://github.com/bitcoin/bitcoin/commit/616a54becbdd6fdb63dbd74e6bf00b682ca308d0). Looks good! I verified that TopUp calls and type checking are not duplicated anymore....
rebased, conflicts solved.
> The first four commits seem fine and could stand alone, but I'm not sure that introducing an entire class for managing the address book is really necessary. I don't...
> @furszy I noticed that you left original methods to deal with address book in CWallet. Some of the are pure proxies. Is that on purpose? Do you have any...
rebased, conflicts solved.
> It's not clear to me that this provides any significant benefit over a much simpler change of just excluding pre-selected inputs from AvailableCoins. The only other improvement this provides...
To make the speed improvements more visible, pushed a new benchmark f6d0bb2d. Basically, the new bench measures the transaction creation process, for a wallet with ~250k UTXO, only using the...
Took me a bit but, while was tackling the feedback, ended up re-organizing the commits changes better. The rationale for each modification should be clearer now. What did was: 1)...
thanks achow101, feedback tackled.
Thanks for the review guys :smile:. > Regarding the bench, it would be nice to have a benchmark for when a user has a few pre-selected inputs and also uses...