Furkat Gofurov
Furkat Gofurov
/remove-lifecycle stale
> Q: for node draining, we have the machine.cluster.x-k8s.io/exclude-node-draining annotation that allows us to skip the process entirely. Should we have something similar for volumeDetach? @fabriziopandini great idea, I was...
> Q: for node draining, we have the machine.cluster.x-k8s.io/exclude-node-draining annotation that allows us to skip the process entirely. Should we have something similar for volumeDetach? @fabriziopandini I have updated the...
I can not reproduce this test failure locally (`make verify-gen` is not throwing any error? tried both 1.17 and v1.18 Go versions ) /test pull-cluster-api-verify-main
> I can not reproduce this test failure locally (`make verify-gen` is not throwing any error? tried both 1.17 and v1.18 Go versions ) Okay, so there was an issue...
/cc @sbueringer @enxebre please take a look when you have some spare time, thanks
> thanks! lgtm after squashing. thanks for the review @enxebre, squashing is done.
> Just some nits Updated accordingly, should be good now. > Thx for pushing this forward! Thanks for all suggestions and help!
@sbueringer @fabriziopandini @enxebre are there any objections to backporting this once merged?
> Created #7233 for tracking related work on Cluster.Topology Thank you, most probably you will be working on it, but in case not, I am also happy to work on...