FUJITA Tomonori

Results 210 comments of FUJITA Tomonori

slightly outdated but here's how to run the CIs locally https://github.com/osrg/gobgp/blob/master/test/scenario_test/README.md I guess that it would be better to have sorta developer guide on the top of the directory.

No.1 IIRC, PattrsBinary can store path attributes in binary format (on wire). mrt injection uses it for the performance (avoid api conversion). No.2 you can improve unmarshalAttribute for bgpls attributes.

Yeah, I made several mistakes on these prefix stuff. But I guess that there are good number of users who use them. I don't think that it's a good idea...

A project such as the following notify GoBGP via gRPC API? https://github.com/jthurman42/go-bfd

I guess that AdminDown/Up should work. All you need to shut down a peer after the failure and then make the peer up after the recovery.

We could have API like WatchEvent to register all kinds of events via a single channel. However, every peer has the own channel to send events (updates, state change, etc)...

Thanks for the report, gobgpd is not designed not to send an notification until sending all the routes in the rib. But unintentionally, gobgpd might work in that way. There...

Thanks for the details! Can you try the latest master? I fixed a bug so CreatingUpdateMsgFromPaths() should finish quickly (less than 3 seconds with the full routes on my laptop)....

I'm happy to accept to a pull request for this feature. Probably adding something like `repeated google.protobuf.Any pattrs` to `ListPathRequest`.

I guess that you don't configure the peer as Route Server. To show routes, you should execute: `gobgp global rib`