Stephen J. Fuhry

icon indicating a website link https://www.tpastream.com

icon company TPA Stream icon location Cleveland, OH icon location Co-founder and CTO at TPA Stream

Results 45 comments of Stephen J. Fuhry

RFC: Remove Nested(many=True) to keep only the List(Nested()) form

@sloria :+1: on depreciating stuff rather than stacking the deck with more BC breaks. I'd much rather have 8 releases with 8 breaking changes than 8 breaking changes in one...

fix: use data_key from field if available to set property name

thanks @martijnthe and @jgroth ! Apologies for not having seen this before now. It looks like this changeset prefers data_key over metadata. Do either of you have a sense for...

Feature request: Support schemas created with marshmallow-oneofschema

This sounds like a great idea! We use oneofschema for some fancy polymorphic stuff and it works great. I've not looked into how that might work with this library, but...

support data_key

Looks like there's been some progress here: #100 but the tests aren't currently passing on that branch

Account for allow_none.

Interesting - ok I think this makes sense. When I glanced at this before I wasn't sure what this was trying to do, but looking into it I found this:...

Integrate Test with setup.py

Any reason putting all the tests in a class `BaseTest`? Thanks for the pull!!

props_ordered does not work for nested fields

Looks like the only thing holding this one back is `black` formatting: https://travis-ci.org/github/fuhrysteve/marshmallow-jsonschema/jobs/749987034

Support for using load_from or dump_to as field titles

Nice catch!

Support for using load_from or dump_to as field titles

I'm afraid I won't be able to get to it for quite some time. But in case you or anyone else are inclined to take a stab at fixing it,...

Provide schema metadata in the "Meta" class

Hey @LukeMarlin thanks for digging in and pulling out some of those answers. Looking [here](https://github.com/fuhrysteve/marshmallow-jsonschema/blob/87a66c1e99a15c4738ead00b448bac3d3340a034/marshmallow_jsonschema/base.py#L248) it is setting `$schema` to "http://json-schema.org/draft-07/schema#".. I wonder if that's simply not in the latest...