GnSight

I read the code carefully today, does the code only work for mmc boot and not for spi nor and nand flash for now?

Thank you for the detailed answer :) I managed to get a Nezha board today which has a 2Gb MX35LF2GE4AD SPI NAND Flash. I am trying to make it able...

> Hi [@ftyghome](https://github.com/ftyghome), > > Before diving into this, did you see [#16908 (comment)](https://github.com/github/codeql/issues/16908#issuecomment-2213507452)? Also could you tell us exactly which CodeQL versions you are using? Hi @jketema, Yes, I...

Hi @jketema, Thanks for tracking this down! Looking forward to hearing about a fix.

Thanks for the update!

Hi emersion, Thanks for the review! I've addressed the comments and added support for XWayland. Please let me know if anything else is needed :)

Thanks for the review! I've moved the foreign-toplevel creation and destruction logic to the map/unmap paths, and moved the duplicated code to view.c. Please let me know if there's anything...

Hi emersion, I've now moved the request_activate and request_close related code to view.c. I noticed that the [view->type == CAGE_XWAYLAND_VIEW](https://github.com/cage-kiosk/cage/pull/451/commits/92789f1a027fe161c12cf201316dc209a18bfdb4#diff-54179c6774602478e8521e09f9d7d26dba0fe105ce0e8147d6af9e292adc2b97R149) check might not be very elegant, but I felt it...

Hi @emersion, I have updated this PR, thanks for the review! Please let me know if there are any other changes needed:)