Nathan Froyd

Results 119 comments of Nathan Froyd

Thanks for sending this. I've thought for a while about the best way to introduce authenticated encryption (AE) with the current interface. Doing it with {EN,DE}CRYPT makes me uneasy, as...

Yes, offering it is the best thing. I agree the most elegant approach is to treat AEAD modes as "just another mode" with some bits added on. But I'm skeptical...

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

> So why is there a manually implemented `Drop` for `Node` ? So that the children are dropped iteratively, not recursively. See PR #384.

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

Green test on Stripe's CI: http://go/builds/bui_NmnpNMSzpFHw0r It doesn't look like this PR noticeably affects test performance (one datapoint is a not a great way to measure this, but at least...

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

> → https://go/builds/bui_PdSCNR29yj78iw → https://go/builds/bui_PdSCuAV1vhiB19 → https://go/builds/bui_PdSCKpfPJSJcG7 These are failing because of a merge race with #7650 ; the errors are unrelated to `Mutex#synchronize`.

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

This PR seems fine from the Sorbet side of things, but it turns up a number of failures on Stripe's codebase, mostly because Sorbet now knows that `ARGV[i]` returns a...