Nathan Froyd

Results 119 comments of Nathan Froyd

We implemented this as part of moving instance variables onto the LSP fast path.

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

I think this is more-or-less ready for review. It should be relatively neutral performance-wise, but I think having everything tied into a single AST node, rather than scattered throughout the...

> I'm surprised that we have a compiler test specifically testing this scenario and mentioning that it is allowed. Any context on why? There is some context here: https://github.com/sorbet/sorbet/blob/9284313547e7328070e32de2b46f7a8ef1bc1b7c/compiler/IREmitter/Payload/vm-payload.c#L405-L450 IIRC,...

How did cc26aa1 fix the test failures in 45ad3a5? Are those tests just flaky in some way?

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

The above build links are for sorbet builds, not sorbet-runtime (we trigger a different set of builds for sorbet-runtime, but those are not posted to github). The Stripe-internal build link...