Mark Frost
Mark Frost
Until this is fixed, is there any way to prevent the socket.io probe from installing? We only use data from other probes.
`appMetrics.disable('socketio')` doesn't help. It looks to me that all probes are installed very early, by the appmetrics index.js, and whether a probe is disabled doesn't affect it attempting to hook...
### Example running this code 1. run a clair: `go run ./cmd/clair/ -conf ./local-dev/clair/config-frostmar-local.yaml -mode indexer` 2. start a longer-running request: `curl -H "Content-Type: application/json" http://localhost:6060/indexer/api/v1/index_report -d ...etc...` 3. CTRL+C...
Reading up with the help of https://dev.to/mokiat/proper-http-shutdown-in-go-3fji I think the current behaviour is due to [srvs.Wait()](https://github.com/quay/clair/blob/6de0d807a5d63d5b10d63c274c297fcf095a308b/cmd/clair/main.go#L181) returning as soon as the servers are `Shutdown()` (stop accepting requests), which runs off...
draft PR https://github.com/quay/clair/pull/1951 improves this a bit, but I can't get in-flight requests to continue processing for a grace period. Details in the draft PR
@crozzy sorry for the bump - just checking if this PR has been overlooked?
>Thinking through re-indexing, will there be a situation where the report is 200OK then is being re-indexed so will be 404Not Found the 200OK again? I think that will happen,...
>... checked in a .vscode file Sorry, sorted now
@crozzy / @hdonnay I'm hoping this can make the next release of Clair, if it looks OK to you now?
@crozzy / @hdonnay bump - can I do anything to progress this please?