Salman Alshamrani

Results 103 issues of Salman Alshamrani

- [x] Depends on #19379 In order to display failed scores with a sane total score and an accuracy that matches the one at the point of fail, `ScoringValues` is...

area:scoring
size/L

- Closes #19302 The previous code of best rank badge orders scores by `TotalScore`, which could be in different algorithms based on the score type (standardised for lazer scores, classic/stable...

area:song-select
size/L

- Addresses https://github.com/ppy/osu/discussions/19321 I was also hoping to remove `BeatmapInfo.MaxCombo` once and for all, but it appears that's not feasible due to the [`APIBeatmap` -> `BeatmapInfo`](https://github.com/ppy/osu/blob/f956955d4d66a6955cafdf066d1c4034b46c64ec/osu.Game/Overlays/BeatmapSet/Scores/ScoresContainer.cs#L80-L88) conversion in `ScoresContainer`, which...

size/XS
area:overlay-beatmap

### Discussed in https://github.com/ppy/osu/discussions/19336 Originally posted by **Nekomosh004** July 23, 2022 Unlike Stable/CE, adjusting the volume in lazer keeps the options up when playing in osu!catch because we use the...

type:UX
priority:2
area:overlay-volume

At face value, it is expected that this flag determines whether the beatmap track is loaded (i.e. `Track.IsLoaded`), but that's not the case, instead, it checks whether the beatmap track...

type:code-quality
area:beatmap

### Discussed in https://github.com/ppy/osu/discussions/19291 Originally posted by **Flamiii** July 22, 2022 ![image](https://user-images.githubusercontent.com/74088315/180353862-eb30cdee-7baf-481f-8319-a69e5166e236.png) So currently in playlists, when you hover over the '-' character next to a user's country flag, it...

type:online
area:playlists
priority:1

- Closes https://github.com/ppy/osu/issues/18003 I've initially intended to look at just adding guards against non-present drawables, but the current logic for filtering out drawables was quite convoluted that I looked at...

blocked
area:drawable
size/L

- Closes #5200 Went with a hold delay of 500ms from real device testing, feels pretty well. The implementation behind this was to trigger a right click and "cancel" the...

area:input
size/L

- Closes https://github.com/ppy/osu-framework/issues/3271 - Resolves the font size discrepancy in https://github.com/ppy/osu/issues/17940 Adds support for CSS-style font sizing, allowing for our sprite text sizes to match 1:1 with CSS. As a...

size/XL
area:fonts

Currently disabling the property would end up making the sprite text look unaligned instead: | | `UseFullGlyphHeight = true` | `UseFullGlyphHeight = false` | |----------------|:---------------------------:|:----------------------------:| | with margin | ![CleanShot...

area:UI
priority:2