Haisheng
Haisheng
Great. Thank you.
Hi @ChrisPenner! Thanks for suggestions! Initially I'm thinking from developer point of view, they shall only set flag like `pkce:true`, and our library would take care generating verifier etc. But...
Are you hinting adding methods to the type class `IDP a` and let each IDP (`IDP/*.hs`) implement? I was trying to avoid type class implementation.
Looks like not all IDP has same domain for authorize and token endpoint years ago. Shall double check now Outliers - dropbox - fitbit - facebook - google
Refactoring idea - authorize and token endpoint is more static. consider create IDP data type that only holds those endpoints - client id, client secret, callback, scope, grant type etc...
Thanks. That looks good. Would be better to allow library User to handler it rather than `hoauth2` default it? I mean like `catchAny authGetJSON' handler` My understanding it'll open flexibility...
I'd prefer the idea that return something like `Left "Unauthorized"` and it probably shall wrap all possible errors that declared by their API. I'm busy those days and hopefully have...
Thanks much! I suspect it'll be at `handleResponse`. Otherwise I'll need to know what exact error and take a close look as well. ``` handleResponse :: Response BSL.ByteString -> OAuth2Result...
The library doesn't swallow the exception. (see `handleResponse` above)
@MichelBoucey nice! will take an look.