fredizzimo

I just noticed that I wrote `linespace` instead of `leading`(linegap) in my previous message. See https://freetype.org/freetype2/docs/glyphs/glyphs-3.html for the meanings. The underline is relative to the baseline, so to get the...

It seems like some fonts don't have an underline position set, in that case the underline thickness should be used as an offset, see how the high level skia API...

Another thing that I noticed is https://github.com/neovide/neovide/blob/1db63d93b18cc1eb5ac5b3e67b3ca63505f10800/src/renderer/fonts/caching_shaper.rs#L224 Should probably be `metrics.ascent + metrics.leading / 2. + self.linespace / 2.` to distribute the font linespace equally, just like our own additional...

I have checked the offset calculation, and IMO it works as it should and renders the same as LibreOffice, for all the fonts I have checked. So, I guess this...

Actually, when thinking more about this, I think we should only support this setting in the font config file. https://neovide.dev/config-file.html#font, so that it can be specified per font and style.

Yes, I think so, if someone has time to do it, I don't think the core team has time for a while. I personally, don't even have access to a...

This approach did not work. I think the best we can do is to either remove reviewdog completely and do a standard `cargo clippy` command. The reviewdog is quite confusing...

This was replaced by: * https://github.com/neovide/neovide/pull/2685

Thanks, I think we will wait a bit still with this. We don't want to introduce an option that we have to deprecate later. We might not have to wait...

This is by design and documented as a breaking change in [0.13.0](https://github.com/neovide/neovide/releases/tag/0.13.0), so I'm closing this. The decision was based on the discussions here https://github.com/neovide/neovide/issues/2147, and the PR was also...