Michał Pachucki

Results 9 comments of Michał Pachucki

it looks like there is a missing test case in commit mentioned by @gregturn , in my case i have such SQL query: ` select u from UserAccountEntity u join...

Ok I see, the QueryUtils.STARTS_WITH_PAREN does not handle newlines in subselects. I'll try to make a MR for that. `private static final Pattern PARENS_TO_REMOVE = Pattern.compile("(\\(.*\\bfrom\\b[^)]+\\))", CASE_INSENSITIVE | DOTALL); `...

It is my first time adding a PR to spring related projects, so I am not sure I've followed all guidelines :)

This issue is blocking my upgrade to spring boot 2.7.0. Is there anything I can do to help in merging this?

@gregturn sorry for calling, but this issue blocks upgrading to newer spring boot versions. It is already fixed in at least three seperate PRs (this one, https://github.com/spring-projects/spring-data-jpa/pull/2582, https://github.com/spring-projects/spring-data-jpa/pull/2603). I don't...

Hi, this looks like almost the same change as the one I've added previously :) https://github.com/spring-projects/spring-data-jpa/pull/2557 Do you know of any way of speeding up the acceptance? Already we have...

This is something I struggled a lot, but it seems that you need to provide includes assuming wsdlDir is already the root. So it should ne just NumberConversion.wsdl Unfortunately the...

Sure, although this class did not have any test that I could find so it might take me a while to understand how to write it in order to be...