Fran Moreno

Results 71 comments of Fran Moreno

Not sure if an `EnumFilter` is needed, I guess using a `ChoiceFilter` with `EnumType` as `field_type` should work.

Hey! I know it's has been a while since the issue was open, but just came across this and it should be fine to just move those lines inside the...

@phansys do you want to take a look at this before releasing next minor version or do we defer this to the next one?

Hi, thanks for the PR! Just a couple of comments, looking at the method calls `->getIdentifier(false, true)` seems a little bit weird to me and the way the ids are...

Not sure if we can do something from the package because the extension sets these variables when persisting/updating. > so that the entity would be valid before it is persisted....

I haven't used this extension either. Since the YAML driver does not exist anymore, I guess I would change `ReferenceIntegrityMappingTest` to use annotations.

The only _problem_ I see here is that [`AttributeReader`](https://github.com/doctrine-extensions/DoctrineExtensions/blob/main/src/Mapping/Driver/AttributeReader.php) must implement `Reader` interface as well, it's not ideal since it would depend on `doctrine/annotations` but I guess we'll be supporting...

> I didn't look at the attributes implementation, but it almost feels like there's either a leaky abstraction or an incomplete abstraction layer if the attribute reader has to have...

There is another usage (it was defined as required because of this): https://github.com/doctrine-extensions/DoctrineExtensions/blob/ddc468bcf40045a5b1606f62296b75c7c2a6a42c/src/Mapping/MappedEventSubscriber.php#L283-L301

I haven't checked the implementation yet, but looking at the docs I guess `Uploadables` is not necessary, `Uploadable` could be repeatable, that would work for attributes using php 8.0. Tests...