Frankie Yan
Frankie Yan
I'm trying to generate classnames similar to webpack's `localIdentName` where its default is a single hash: https://webpack.js.org/loaders/css-loader/#localidentname With a single `hash` token provided to `generateScopedName`, it looks like it's generated...
Hi there, it looks like when a `modules` config object is provided, then the regex match using `autoModules` is ignored: https://github.com/Anidetrix/rollup-plugin-styles/blob/e09ac0927053ffba52410e1d36b6b1c74ae63155/src/loaders/postcss/index.ts#L49 For example, using a configuration like the following would...
Closes https://github.com/Doist/reactist/issues/679 ## Short description This re-implements the modal with Ariakit. It tries to match the previous implementation as close as possible, both API and markup wise, so we don't...
As addon-knobs is deprecated ([ref](https://github.com/storybookjs/addon-knobs/tree/v6.4.0#storybook-addon-knobs-deprecated)), it should be replaced with [@storybook/addon-controls](https://storybook.js.org/docs/react/essentials/controls). There are only two stories (avatar, keyboard-shortcuts) left that are using knobs.
## 🚀 Feature request Reported in https://github.com/Doist/reactist/pull/680#discussion_r945869248 The `ColorPicker` is built using the now-deprecated `Dropdown` component (see https://github.com/Doist/reactist/pull/680). To be able to remove the component, it needs to be re-implemented...
We rely on Reach-UI's [Dialog](https://github.com/reach/reach-ui/tree/v0.17.0/packages/dialog) component to power our [Modal](https://github.com/Doist/reactist/tree/v12.1.1/src/new-components/modal). In Todoist, there are 11 modals built using the Reactist Modal, and 27 in Twist. Todoist also pulls in @reach/dialog...
## 🚀 Feature request Currently, storybook uses webpack to bundle both our components and stories together, while our dist build artifacts are being built with tsdx/rollup. This will be prone...
## 🐛 Bug report ### Current behavior It's possible for a consuming app to also have [React Focus Lock](https://github.com/theKashey/react-focus-lock) installed, and if the version used in Reactist can't be deduped...
## 🐛 Bug report ### Current behavior In our product library, dividers and borders are different colours and have different semantic meaning. [Related figma discussion](https://www.figma.com/file/CiZwQEtbChKpgYCCM3Ln7S?node-id=1462:189466&mode=design#703269424) ### Possible solutions - Expose...
## Short description This fixes the alignment for icons in the `` component, spotted by @pauloslund over at https://github.com/Doist/todoist-web/pull/8223#pullrequestreview-1706995679 ## PR Checklist - [ ] Added tests for bugs /...