Félix Queiruga

Results 6 comments of Félix Queiruga

I think this should be solved on core. These are YUI styles for modals, so maybe the fix can be put on https://github.com/jenkinsci/jenkins/blob/master/war/src/main/less/base/yui-compatibility.less

Approving the CSS code (it's namespaced) and JS code (was only moved). I've got a few comments regarding potential XSS vectors. Other than that looks solid

One more question. Any chance you can use the same tab templates as provided by Jenkins core? Maybe you could even extend them if you need it. Their colours and...

This is a great initiative. I have 2 pieces of feedback for now: - I would suggest using react hooks instead of class components. It's more future-proof and easier to...

> Does that mean using function components along with useState()? Indeed. > Would you suggest using React Bootstrap or picking up components from npm and writing my own CSS? Depends...