Florent Peterschmitt
Florent Peterschmitt
The `vips.h` file has to be updated to, for example, ~~use a generic "option" struct that could be reused and all optional parameters be set in the "loader" calls.~~ i...
I don't think what i came with is good: * The Formatter has a dependency on Context and Reporter. I think it should be the opposite, where the Reporter *may*...
Another thing: the `Failure` struct contains the `assertionName` and two values. But that doesn't always apply: for example the "NotEmpty" or "Item" assertions/helpers cannot really return an expected value. So...
Or then `expected` of `Failure` can contain predefined values: ``` var ExpectedEmpty = Value{...} var ExpectedNotEmpty = Value{…} … ``` probably way simpler :smile: but doesn't work for "expected length"
@gavv gentle ping ^^
> @Leryan Thanks a lot for PR, much appreciated! I was hoping to review it on this week, but it seems I'll have a chance only on the next one,...
> For example, we can split Formatter into two entities: > > * the first one is doing only one thing: formatting; we may keep the name Formatter for it,...
@gavv hey there :) i've pushed a substantial amount of changes, i think this is close to what you want. Also, i used a bit of a trickery with the...
> Please let me know if you would like to leave some issues unresolved in this PR and postpone them to future PR(s). It's ok since we're merging into a...
hello @gavv could you ensure that the context branch is in sync with master so i can update my branch as well? thanks :)