Aleksei Potapkin comments

Results 9 comments of


                                            Aleksei Potapkin

crytic_compile.platform.exceptions.InvalidCompilation: Unknown file: contracts/hardhat-dependency-compiler/@openzeppelin/contracts/access/AccessControlEnumerable.sol

Also, it can be reproduced in this repo https://github.com/aave/governance-crosschain-bridges ``` Traceback (most recent call last): File "/Users/folk/.local/pipx/venvs/slither-analyzer/lib/python3.10/site-packages/slither/__main__.py", line 744, in main_impl ) = process_all(filename, args, detector_classes, printer_classes) File "/Users/folk/.local/pipx/venvs/slither-analyzer/lib/python3.10/site-packages/slither/__main__.py", line...

Dynamic apk names

Thanks for the workaround. I got your point, but still think that passing apkNames through CLI arguments, e.g. `marathon --applicationApk app-v.2.0.apk --applicationTestApk app-androidTest.apk` can be intuitive and flexible because of...

Lido V2: initial doc rework

> One discrepancy nice to unify is "Callable only by owner" and "Reverts if `msg.sender` is not owner", wdyt? TBH, not really get the context.

Unify natspec asterisks identation

Looks like we are going to use `///` for natspec.

Define policy for tests

I'd rather prefer option 1 right now. With possible expansion to option 2 when we figure out a robust API for it. Just to reduce the number of entities.

Maybe emit transfer events inside of _transferShares()

Looks like everything changed significantly with V3 release and this issue is not actual anymore

🐛 [BUG] - Memory Leakage with VSCode extension

Can confirm on Mac os x. Python process leaks like crazy, I have seen 32G. Will be grateful for a fix.

Unable to publish aragon apps dependency

Closing as outdated

Add TRP and Matic voting items (mvp)

Closed as it's decided to go with a separate aragon voting for operational items.