Faraz Yashar

Results 29 comments of Faraz Yashar

Apologies if a pull request was inappropriate. I'm fairly new to the git workflow. There are still some encoding and output comparison errors when running the tests. However, loading issues...

I submitted a similar patch to fix the issue in the gem entirely. The test yields errors when comparing the expected HTML output, and I similarly encoding errors crop up...

Not sure what's up, but there's a test from something outside the scope of my changes that's failing on the latest build (weirdly [264.11 alone](https://travis-ci.org/laserlemon/figaro/builds/61971438)). Everything was passing the first...

Yes, but I cheated. I just pushed a change to the README, and all is well. It looks like there's a bug elsewhere Figaro that makes that spec randomly fail...

No. @laserlemon just seems uninterested in this feature. There were no conflicts when this PR was originally made, it's just been sitting around for awhile.

Thoughts on the best way to extract these parts for reuse? I'm thinking a mixin might do. ``` ruby def vars configuration.keys.map { |k| var(k) }.join(" ") end def var(key)...

I'll give it a go. I managed to fix it by adding `Figaro.load` to the top of the `class Application...` bit.

Would it be enough if I set up a sample rails application? On Tue, Apr 21, 2015 at 10:24 PM, Steve Richert [email protected] wrote: > There's already a test >...

I'm actually not sure about where to put this in the tests, but it's simple to reproduce: Here's the repo: https://github.com/fny/figaro_fail/commits/master With a vanilla Rails 4.2 app (`rails new figaro_fail`)...

So I'm thinking this is a regression in Rails, since this was working before Rails 4.2. The problem you stated is exactly correct, the `before_configuration` hook is actually never run...