Jim Graham

Results 131 comments of Jim Graham

A single horizontal pixel line located right around the bottom of the embedded view flashes white, but only while a scroll is happening. If you pause your finger it goes...

Also, if I remove the clipRect(kDifference) it goes away. It would appear that Impeller and Skia have different concepts on how to apply that clip. I'm guessing the fact that...

~The clipRect is a non-AA clip rect, but I don't know if Impeller implements non-AA rendering even for clips.~ @bdero? Since the rects are "roundOut()"ed in device space the AA...

Another thought is that since the view looks correct when the motion stops, perhaps we are just seeing "screen tearing" as the multiple layers are submitted to the compositing engine...

Doing this here when the Picture is generated amortizes the cost well. It would be even better if there was an off-line tool that could optimize an SVG file.

The reason the saveLayer tests trigger the optimization is that they have a rendering op specifically inserted to *prevent* NOP optimization, and that op successfully prevents Skia from removing the...

The issue with the dl_unittests is likely that we have a whole suite of save-type calls that are all dumped into the DisplayLists being constructed without any regard for whether...

I should clarify in the original issue. The concept here was not to just eliminate an extra Dispatch process, but to integrate the 2 mechanisms so that they could share...

Unfortunately we're going to need the Calculator class for just a little while longer while we solve a pressing need to get more coverage for Impeller. The PlatformViews will need...

I tagged you in https://github.com/flutter/engine/pull/34809 so that we can plan the more forward on how to integrate bounds calculation while also considering the need for an RTree.