Fisher Darling
Fisher Darling
> Some changes needed, but overall looks good. The new methods need to have option arguments and we need to add testing for this in `worker-sandbox`. Miniflare support for DO...
@zebp Currently stuck on testing. A few days ago I tried to add some and I don't think I was able to get it to work locally. Are my testing...
> Not quite sure how but maybe we should add a step to CI that somehow verifies that tokio isn't pulled in when this feature isn't enabled. Otherwise I imagine...
@davidpdrsn I'm currently blocked on trying to figure out CI. `cargo check -p axum --no-default-features --target wasm32-unknown-unknown` is failing for me, even though I can successfully use this fork to...
@davidpdrsn I was actually able to get it to work! I've actually switched almost all of my worker code to use the router, which has been extremely nice to have....
> So do you need the `Router` for your wasm use case or not? If not, should that be the unit that's made optional maybe? @jplatte I do need the...
> Then what did you mean by > > > The "true" fix would be to separate the router into an `axum-router` crate and let people just pull that in....
I completely agree and understand. I remember when tokio had so many `tokio_*` crates and how that was confusing for many people. > I'm gonna try and take a look...
Hey all, sorry for being MIA! I just started a new job and have been pretty busy these past couple of months. @logankeenan I'm glad the PR worked for you...
@logankeenan feel free to ping me `@fisher` in the axum Discord if you'd like :)