Fiona Liao

Results 12 comments of Fiona Liao

@aboroska I'll review this, sorry for the long delay.

> I added some commits to make the CircleCI package build pass - not sure if they are useful, or perhaps more appropriate for a separate pull request. I think...

I haven't finished writing additional tests yet, but it's ready for a quick review to check I'm on the right track. I'd recommend going through each commit separately because there's...

> All references to "remove in Mimir 2.9.0" should change to "remove in Mimir 2.10.0" because we haven't made this PR in time for 2.7, so the change will be...

I won't be available for the next two weeks, after that I'll keep working on the PR. The main tasks remaining are: making sure he shuffle sharding lookback and `UseQueryable()`...

Apologies for the long delay, but this PR is ready to review again. I think I've covered all the comments and taken it out of draft mode. Since it has...

> make processWBLSamples and processWALSamples look similar I'm planning to take this task. I've been working on out or order support for native histograms. Making `processWBLSamples` and `processWALSamples` more similar...

I think these are the updates that need to be made: - chunks.md - add float histogram chunk format - head_chunks.md - ooo mask for encoding - wal.md - add...

Inspired by https://github.com/prometheus/prometheus/issues/13934, making a table with all the functions/operators that could try to combine two native histograms. This table will have further edits. | name | expected behaviour |...

For the functions and operators that have been implemented for native histograms, all the incompatible schemas are being handled properly so no new implementation was needed, just tests have been...